@baywet opened this Issue on June 26th 2018

Hi,
I've been the main French translator for a while now and I'm working on translating the latest tag manager release.
Label with key TagManager.UrlParameterVariableDescription reads "Get the value of a specific URL parameter." however all similar labels read "GetS the value…."
I believe an S is missing and the label should be updated.

@sgiehl commented on June 26th 2018 Member

@baywet thanks for the report. You can report tag manager related stuff also directly in the tagmanager repo: https://github.com/matomo-org/tag-manager/issues

@sgiehl commented on June 26th 2018 Member

Btw. There are currently two strings starting with Get the and four starting with Gets the. See https://github.com/matomo-org/tag-manager/blob/master/lang/en.json#L418-L420
We should use the same wording everywhere I guess, but not sure which one is better... @tsteur

@baywet commented on June 26th 2018

Hi Stefan,
Should I close this issue and re open on the other repo out can keep investigating on this one exceptionally?

@sgiehl commented on June 26th 2018 Member

No need to create a new one there. Shouldn't be a big thing to change it, so we can leave it here and close once it's done.

@tsteur commented on June 26th 2018 Member

Don't know which one is better, maybe Gets the ...?

@baywet commented on June 26th 2018

most of the other variables are documented with Gets the… it would be consistent at least

This Issue was closed on June 28th 2018
Powered by GitHub Issue Mirror