Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in TagManager.UrlParameterVariableDescription Enlgish version #13106

Closed
baywet opened this issue Jun 26, 2018 · 6 comments · Fixed by matomo-org/tag-manager#31
Closed

Typo in TagManager.UrlParameterVariableDescription Enlgish version #13106

baywet opened this issue Jun 26, 2018 · 6 comments · Fixed by matomo-org/tag-manager#31
Assignees
@tsteur
Labels
c: i18n For issues around internationalisation and localisation. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@baywet
Copy link

baywet commented Jun 26, 2018

Hi,
I've been the main French translator for a while now and I'm working on translating the latest tag manager release.
Label with key TagManager.UrlParameterVariableDescription reads "Get the value of a specific URL parameter." however all similar labels read "GetS the value…."
I believe an S is missing and the label should be updated.
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Jun 26, 2018
@sgiehl
Copy link
Member

sgiehl commented Jun 26, 2018

@baywet thanks for the report. You can report tag manager related stuff also directly in the tagmanager repo: https://github.com/matomo-org/tag-manager/issues

@sgiehl
Copy link
Member

sgiehl commented Jun 26, 2018

Btw. There are currently two strings starting with Get the and four starting with Gets the. See https://github.com/matomo-org/tag-manager/blob/master/lang/en.json#L418-L420
We should use the same wording everywhere I guess, but not sure which one is better... @tsteur

@sgiehl sgiehl added the c: i18n For issues around internationalisation and localisation. label Jun 26, 2018
@baywet
Copy link
Author

baywet commented Jun 26, 2018

Hi Stefan,
Should I close this issue and re open on the other repo out can keep investigating on this one exceptionally?

@sgiehl
Copy link
Member

sgiehl commented Jun 26, 2018

No need to create a new one there. Shouldn't be a big thing to change it, so we can leave it here and close once it's done.

@tsteur
Copy link
Member

tsteur commented Jun 26, 2018

Don't know which one is better, maybe Gets the ...?

@baywet
Copy link
Author

baywet commented Jun 26, 2018

most of the other variables are documented with Gets the… it would be consistent at least

@tsteur tsteur self-assigned this Jun 27, 2018
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 27, 2018
@tsteur tsteur mentioned this issue Jun 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: i18n For issues around internationalisation and localisation. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve wording of some parameters and settings matomo-org/tag-manager
3 participants
@tsteur @sgiehl @baywet