ensure Updater::getComponentUpdates returns null if no update is available #13102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
|
Appears to work just as in 3.x-dev (except for core:archive behavior). If there are no updates to run, UI updates version and continues to dashboard. If there are updates to run, both core:archive & UI block. |
|
Actually, I wonder if the donation update page is supposed to be displayed on every update? @mattab it's not currently displaying if a version bump has no Update files. I suppose on cloud it shouldn't be displayed and of course non-admin users probably don't want to see it... |
|
it is fine to keep the current behavior (it is best to display it from time to time only.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure if this change might not also skip some core update screens in UI if no updates need to be executed
fixes #13017