Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use translation for console update success message #13100

Merged
merged 4 commits into from Jun 25, 2018
Merged

Use translation for console update success message #13100

merged 4 commits into from Jun 25, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 24, 2018

fixes #13099

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 24, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Jun 24, 2018
@diosmosis
Copy link
Member

There are some other lines that aren't translated, should these be translated too? Eg:

image

(excluding the SQL of course)

@sgiehl
Copy link
Member Author

sgiehl commented Jun 25, 2018

you're right... Guess it doesn't hurt to make the full command translated 🙂

@sgiehl
Copy link
Member Author

sgiehl commented Jun 25, 2018

Command should now be fully translatable

@diosmosis diosmosis merged commit afcffaa into 3.x-dev Jun 25, 2018
@diosmosis diosmosis deleted the consoleupdatemsg branch June 25, 2018 22:02
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Use translation for console update success message (matomo-org#13100)
992db15 
* Use translation for console update success message

* Replace Piwik w/ Matomo in core:update output

* fix integration test

* makes update command fully translatable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

console based db upgrade refers to Piwik
2 participants
@sgiehl @diosmosis