@diosmosis opened this Pull Request on June 21st 2018 Member

Changes:

  • Introduce new containerId parameter sent by widget containers when getting child widgets. If found in a request, ViewDataTable will look for persisted ViewDataTable parameters.
  • containerId is appended to the option name for persisted parameters when present. This separates reports used within widget containers from the same reports used outside of widget containers. So if a user adds a metric to the Visits Overview (with graph), the change won't affect the Visitors > Overview page.
  • Call CoreHome.saveViewDataTableParameters when a report is either not in a widget (as before), or is in a widget but is in a widget container (new).

Fixes #11499

@diosmosis commented on June 25th 2018 Member

Updated the PR

@eramirezprotec commented on January 15th 2020 Contributor

Hi! @sgiehl @diosmosis

When entering to, for example, Visitors -> Devices, and changing the visualization of the Device type (any report, actually) report to a vertical bar graph, and then selecting any metric, one request is being made:

https://XXX/index.php?date=today&module=CoreHome&action=saveViewDataTableParameters&report_id=DevicesDetection.getType&containerId=&idSite=YY&period=day

With the following response:

<div class='alert alert-danger'><strong>Error:</strong> Setting parameters rows_to_display is not allowed. Please report this bug to the Matomo team.</div>

I tried the same in the Matomo Demo and the response received is this one:

<div class="alert alert-danger"><p><strong>Error:</strong> Your session has expired due to inactivity. Please log in to continue.</p><p><a href="index.php?module=Login">Sign in</a></p></div>

I'm guessing the metric(s) selected can't be persisted, and it's ok, but why creating an error and leaving it in the Apache log? If it's supposed to be expected behavior.

Thank you very much!

This Pull Request was closed on June 26th 2018
Powered by GitHub Issue Mirror