Ignore IP Whitelist for Opt Out IFrame #13075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
tsteur
reviewed
Jun 18, 2018
plugins/CoreHome/LoginWhitelist.php
Outdated
| @@ -33,6 +33,11 @@ public function shouldCheckWhitelist() | |||
| return false; | |||
| } | |||
|
|
|||
| // ignore whitelist checks for opt out iframe | |||
| if ('CoreAdminHome' === Common::getRequestVar('module', '') && 'optOut' === Common::getRequestVar('action', '')) { | |||
There was a problem hiding this comment.
Maybe use Piwik::getModule()/getAction() instead?
It looks otherwise fine. Searched again through code base to make sure we are not using any $_GET/$_POST['module/action'] directly and it can also not be passed through API requests as it would mean module=API. Not sure if we render any URLs otherwise without module/action that would allow avoiding this check.
There was a problem hiding this comment.
Maybe use Piwik::getModule()/getAction() instead?
changed.
sgiehl
force-pushed
the
optoutipwhitelist
branch
from
81d56bd
to
b4d9828
Compare
|
Haven't tested it but looks good otherwise. |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Ignore IP Whitelist for Opt Out IFrame * Prevent bypassing IP Whitelist check while tracking if authentication is required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13066