Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend multi_server_environment #13074

Open
daylicron opened this issue Jun 18, 2018 · 3 comments
Open

Extend multi_server_environment #13074

daylicron opened this issue Jun 18, 2018 · 3 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
For Prioritization

Comments

@daylicron
Copy link

daylicron commented Jun 18, 2018 •
edited

We're running a cluster of four Matomo Servers for Load Balancing and Backup. It's running smooth and fine, managed via Puppet.

We're using multi_server_environment=1 in the configs, which works for the marketplace as intended. But someone who needs to work as a admin in Matomo performed a Matomo upgrade via the webinterface, which got us into trouble.

I would like multi_server_environment=1 to disable the Matomo webinterface upgrade as well as plugin installation via marketplace. Actually when you're hovering over the update information, it says that you cannot perform the upgrade. But when you click the information button, the update page says that the upgrade can be performed and allows you to do it.

I tried to get into the code and implement it myself but I didn't even find where multi_server_environment=1 disables the plugin installation...
@daylicron
Copy link
Author

Could anyone take a look at this or give me a hint where to take a look?

@mattab
Copy link
Member

mattab commented Jun 28, 2018

Hi @daylicron
Thanks for reporting the issue. Respecting the setting is indeed important. It would be great if you could create a Pull Request 👍

The code may be around these methods:

matomo/core/SettingsPiwik.php

Lines 273 to 285 in 82a9b1b

/**
* Detects whether an auto update can be made. An update is possible if the user is not on multiple servers and if
* automatic updates are actually enabled. If a user is running Piwik on multiple servers an update is not possible
* as it would be installed only on one server instead of all of them. Also if a user has disabled automatic updates
* we cannot perform any automatic updates.
*
* @return bool
*/
public static function isAutoUpdatePossible()
{
return !self::isMultiServerEnvironment() && self::isAutoUpdateEnabled();
}
then you'd need to block access to the screens in plugins/CoreUpdater/Controller.php at least oneClickUpdate,oneClickResults, index, runUpdaterAndExit when !isAutoUpdatePossible

@daylicron
Copy link
Author

Hi @mattab
we worked out a fix for this: #13201

@Findus23 Findus23 added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
4 participants
@mattab @Findus23 @daylicron @innocraft-automation