@diosmosis opened this Pull Request on June 10th 2018 Member

Work in progress, more to follow.

@fdellwing commented on June 21st 2018 Contributor

Will this PR make #13036 work in tests?

@diosmosis commented on June 21st 2018 Member

Commented on the other issue. This PR probably won't be finished for a while unfortunately :)

@sgiehl commented on June 24th 2018 Member

@diosmosis do you need help finishing this PR? Could maybe help converting some tests when I have some time in between...

@diosmosis commented on June 24th 2018 Member

I was actually doing this in my spare time but it took longer than expected (was hoping to finish in a weekend), and now I don't have the spare time. Would be happy for the help, feel free to push directly to the branch if you'd like @sgiehl!

Note: in order to run the tests, you should just have to do an npm install (w/ node 8 or above) in the tests/lib/screenshot-testing dir, then just run ./console tests:run ... as usual. Still need to have the right fonts & everything. On a mac I can only run them locally through docker (well, run them & have the tests pass).

@sgiehl commented on July 17th 2018 Member

@diosmosis I've rebased the branch on latest 3.x-dev and added more conversions. Most core tests are now converted, but there are some tests failing due to failing requests and I couldn't find out why. I've added the last commit to fix some failing requests for the logos, but that one should be removed again as soon as we know why the requests were failing in the first place. Maybe you have an idea.

Powered by GitHub Issue Mirror