Work in progress, more to follow.
Commented on the other issue. This PR probably won't be finished for a while unfortunately :)
@diosmosis do you need help finishing this PR? Could maybe help converting some tests when I have some time in between...
I was actually doing this in my spare time but it took longer than expected (was hoping to finish in a weekend), and now I don't have the spare time. Would be happy for the help, feel free to push directly to the branch if you'd like @sgiehl!
Note: in order to run the tests, you should just have to do an
npm install (w/ node 8 or above) in the tests/lib/screenshot-testing dir, then just run
./console tests:run ... as usual. Still need to have the right fonts & everything. On a mac I can only run them locally through docker (well, run them & have the tests pass).
@diosmosis I've rebased the branch on latest
3.x-dev and added more conversions. Most core tests are now converted, but there are some tests failing due to failing requests and I couldn't find out why. I've added the last commit to fix some failing requests for the logos, but that one should be removed again as soon as we know why the requests were failing in the first place. Maybe you have an idea.
@diosmosis I've rebased and update this branch with latest changes on 3.x-dev. ~90% of tests are already passing, but there's still some work left. Maybe you have some time in between to work on some of the stuff:
👍 will make some time for it. It's very annoying to have UI tests that never consistently pass, hope this can be merged soon.
The installation test failure is due to https://github.com/GoogleChrome/puppeteer/issues/3471. W/o request interception it works. There was a recent commit in puppeteer to try and resolve this, but it doesn't seem to help in this case.