New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set higher expiry time for the "Ignore tracking" cookie #13042
Comments
Why should we change that to 13 months instead of 2 years? |
Hi, I am pretty sure this getss overwritten on every cookie. In addition this can be configured for every cookie in the config.ini.php. See e.g. here: Line 699 in 947b6b8
In addition the tracking cookies can be configured in JS were they are set: |
The tracking ignore cookie is set to 2 years currently indeed in https://github.com/matomo-org/matomo/blob/3.5.0/core/Tracker/IgnoreCookie.php#L51 There should be actually no expire date? For all other tracking cookies such as the 3rd party tracking cookie the default is (should) be set to 13 months through config as @Findus23 pointed out. |
As it was mentioned the cookie length can be configured in the config. AFAIK it was set to 13 months as a recommendation by eg the CNIL etc. which required a 13 month or shorter cookie length to not needing consent when using Matomo. As for the ignore cookie this expiry time should be indeed longer and I will change this in a PR |
fix #13042 By default two years is set.
fix #13042 By default two years is set.
In Cookie.php, the expiry time is 2 years ; this should be changed to 13 months 馃 Thanks.
/**
* Returns the default expiry time, 13 months
*
* @return int Timestamp in 13 months
*/
protected function getDefaultExpire()
{
return time() + 86400 * 365 + 86400 * 28;
}
Thanks.
The text was updated successfully, but these errors were encountered: