Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executable bit on most files #13038

Merged
merged 1 commit into from Jun 28, 2018
Merged

Remove executable bit on most files #13038

merged 1 commit into from Jun 28, 2018

Conversation

PowerKiKi
Copy link
Contributor

Only the files declaring a shebang have their execution bit set.
Everything else is not executable to avoid possible security issues.

Content of files remains intact.

Only the files declaring a shebang have their execution bit set.
Everything else is not executable to avoid possible security issues
@PowerKiKi
Copy link
Contributor Author

It seems tests are failing because they are flaky, and not because of this change.

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be safe to merge

@mattab mattab added this to the 3.6.0 milestone Jun 26, 2018
@sgiehl sgiehl merged commit ac07aa4 into matomo-org:3.x-dev Jun 28, 2018
@PowerKiKi PowerKiKi deleted the executable-bit branch June 28, 2018 13:06
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Only the files declaring a shebang have their execution bit set.
Everything else is not executable to avoid possible security issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants