Adds option to sync system test files command to directly copy files to expected directory #13012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to expected directory
sgiehl
added
c: Tests & QA
|
@sgiehl could this be the default behavior maybe? or does it make more sense to copy files to processed? (i thought we mostly want to copy them to 'expected' folder) |
|
@mattab didn't create that command in the first place, so not sure what the purpose was. For me it makes more sense to copy it to expected. But if we change default, we should also rename the command. |
|
I was wondering as well, as to me it makes not even sense to copy to processed?! so feel free to go ahead and rename and remove option and make it the default. Cc @diosmosis maybe has some thoughts |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
… to expected directory (matomo-org#13012)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it's better to directly copy the files to the expected folders, as it saves time as the files do not need to be copied from processed to expected for each plugin