Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More visible row actions #13010

Closed
wants to merge 1 commit into from
Closed

More visible row actions #13010

wants to merge 1 commit into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 30, 2018

The row actions are so powerful but they are barely visible. Instead it would be great if they got more attention and this way we give the brand color also more shine :)

Later might change it to some green or some other color we will see.

The row actions are so powerful but they are barely visible. Instead it would be great if they got more attention and this way we give the brand color also more shine :)

Later might change it to some green or some other color we will see.
@tsteur tsteur added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review labels May 30, 2018
@tsteur tsteur added this to the 3.6.0 milestone May 30, 2018
@mattab
Copy link
Member

mattab commented May 31, 2018

Really like the idea of making the row icons more visible.... But can't say that red icons work in this case. Could we use another color but not the red one?

@tsteur
Copy link
Member Author

tsteur commented May 31, 2018

Yes we would have used a nice green but that creates complexity for themes etc. And as said we will likely change the color again indirectly once we possibly change the brand color.

@mattab
Copy link
Member

mattab commented May 31, 2018

Ok then let's wait for the change of color 👍 (these icons in red are not possible IMO)

@diosmosis
Copy link
Member

Since this PR as is shouldn't be merged (if I'm reading the thread correctly), changing label back to WIP.

@diosmosis diosmosis added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. and removed Needs Review PRs that need a code review labels Jun 1, 2018
@mattab mattab removed this from the 3.6.0 milestone Jun 1, 2018
@mattab mattab added this to the 4.0.0 milestone Jun 26, 2018
@tsteur
Copy link
Member Author

tsteur commented Jul 22, 2019

This was already done I Think

@tsteur tsteur closed this Jul 22, 2019
@tsteur tsteur deleted the visiblerowactions branch July 22, 2019 23:23
@mattab mattab removed this from the 4.0.0 milestone Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants