Support both LFS pointers and full objects in ReleaseCheckListTest::test_screenshotsStoredInLfs #13009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c960657
force-pushed
the
check-lfs-files
branch
4 times, most recently
from
e1b93c5
to
d3492a4
Compare
|
Thanks for the PR. As we won't ever have whitespaces in filenames that should work 👍 |
mattab
changed the title
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit\Integration\ReleaseCheckListTest::test_screenshotsStoredInLfs()fails if the screenshots in LFS have been fetched usinggit lfs pull. This changes the output ofgit lfs ls-filesfromto
The difference is only the state of the local working directory, so the test should allow both.