Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matomo falsely says a segment will be preprocessed when browser archiving is disabled & enforced #13000

Closed
tsteur opened this issue May 28, 2018 · 7 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented May 28, 2018

When you configure segments with "real time archiving" and only later enable "enforce disable browser archiving" so that segments are only processed during cli archiving, then it still shows "AND 1 RESULT IS AVAILABLE, USE UP AND DOWN ARROW KEYS TO NAVIGATE.SEGMENTED REPORTS ARE PRE-PROCESSED (FASTER, REQUIRES CRON)" for these segments even though they are not being pre-processed.

You can reproduce this by creating a regular segment "processed in real time". Then add the following config settings:

[General]
browser_archiving_disabled_enforce = 1
enable_general_settings_admin = 0
enable_browser_archiving_triggering = 0

This is not only problematic when people enable this setting later, but it could be also problematic when moving / migrating a DB to another Matomo where this setting is disabled.

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label May 28, 2018
@tsteur
Copy link
Member Author

tsteur commented May 28, 2018

Or alternatively, Matomo needs to actually pre-process all segments.

@mattab mattab added this to the 3.12.0 milestone Jun 18, 2019
@mattab
Copy link
Member

mattab commented Jun 18, 2019

Good find!

Or alternatively, Matomo needs to actually pre-process all segments.

For now I would just fix the bug itself. Maybe we could also actually pre-process all segments eventually (but let's create another issue).

@tsteur
Copy link
Member Author

tsteur commented Oct 22, 2019

We'll implement that when browser_archiving_disabled_enforce = 1 we archive all segments. It's easiest fix and most user friendly.

@tsteur tsteur modified the milestones: 3.13.0, 3.14.0 Nov 5, 2019
@mattab mattab modified the milestones: 3.14.0, 4.1.0 Nov 6, 2019
@sgiehl
Copy link
Member

sgiehl commented Dec 2, 2020

Just looked through the code and if I see that correctly that was already implemented I think with #15499
@diosmosis is that correct?

@diosmosis
Copy link
Member

@sgiehl I don't think so, if a segment is set to processed in real time and browser_archiving_disabled_enforce = 1, then core:archive shouldn't launch it. Would be easy to change though, I think the change would be in SegmentArchiving.

@sgiehl
Copy link
Member

sgiehl commented Dec 14, 2020

Isn't that what this code should do:

private function getShouldForceArchiveAllSegments()
{
return !Rules::isBrowserTriggerEnabled() && !Rules::isBrowserArchivingAvailableForSegments();
}

@diosmosis
Copy link
Member

Yes, which means this has been implemented for quite a while. Tested locally and it works as @tsteur describes, so I'll close this for now.

@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

4 participants