Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zen icon duplication after update check #12997

Merged
merged 1 commit into from May 30, 2018
Merged

Fix zen icon duplication after update check #12997

merged 1 commit into from May 30, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 27, 2018

fixes #12990

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 27, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone May 27, 2018
@diosmosis
Copy link
Member

When I tested this locally on chrome I see this:

image

Looks like response = $('#header_message', $(response)); doesn't select anything, though I'm not sure why.

@sgiehl
Copy link
Member Author

sgiehl commented May 30, 2018

should work now

@diosmosis diosmosis merged commit e26a445 into 3.x-dev May 30, 2018
@diosmosis diosmosis deleted the zenicon branch May 30, 2018 19:15
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After clicking "Check for updates" button, the "zen menu" icon is displayed twice
2 participants