Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal API example #12996

Merged
merged 1 commit into from May 28, 2018
Merged

Remove internal API example #12996

merged 1 commit into from May 28, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 27, 2018

See matomo-org/developer-documentation#246 and as suggested in matomo-org/developer-documentation#246 (comment) removing the example from the Matomo repository as well.

@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review labels May 27, 2018
@tsteur tsteur added this to the 3.6.0 milestone May 27, 2018
@diosmosis
Copy link
Member

Regarding a reason not to use HTTP requests, is there potentially an issue w/ using outgoing HTTP requests on shared hosting? (I don't know if there is, but when thinking about why this code exists, the thought came up that there might be.)

@tsteur
Copy link
Member Author

tsteur commented May 27, 2018

Possible that a server isn't connected to the internet, but as this example is executed on the same Matomo server, it should still be able to at least connect to itself I would say. Otherwise HTTP requests itself should work. Not sure what the reason is. It was mentioned in the docs regarding resources, but HTTP doesn't take many resources (maybe was valid 8-10 years ago IDK)

@diosmosis
Copy link
Member

Yeah, I'm not sure what resources it would take up either. And if there is a performance issue w/ using HTTP requests, we should optimize that use case instead of creating another solution that has to be supported. 👍 to remove

@tsteur
Copy link
Member Author

tsteur commented May 27, 2018

And if there is a performance issue w/ using HTTP requests, we should optimize that use case instead of creating another solution that has to be supported.

It should do pretty much the same logic anyway. I think the reference was to the resources of an HTTP request itself. But HTTP itself really doesn't take any resources basically and it is very fast.

@mattab mattab merged commit 51e725e into 3.x-dev May 28, 2018
@sgiehl sgiehl deleted the removeinternalapiexample branch August 1, 2018 16:10
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants