@sgiehl opened this Pull Request on May 26th 2018 Member

fixes #11102

@tsteur commented on May 27th 2018 Member

FYI: We'll need to check and adjust some plugins as well (not part of this PR) like Users Flow, Attribution, Funnels, ...

I presume people will see afterwards a drop in websites referrer types? I wonder if we need to mention in a blog post and explain they are now attributed differently?

@sgiehl commented on May 27th 2018 Member

I presume people will see afterwards a drop in websites referrer types?

I'm wondering if it maybe would make sense to automatically add an annotation to referrer type report on the day of update to point that out?

@tsteur commented on May 27th 2018 Member

Could do it maybe for a week after the update or so?

@sgiehl commented on June 17th 2018 Member

Ready for a first review. Open todos:

  • [x] Update CHANGELOG
  • [ ] Maybe add update script to add annotation
  • [ ] Update UI files and maybe OmniFixture
@diosmosis commented on June 19th 2018 Member

For dates before this goes into effect, I see that 'Social Networks' isn't added to the "Referrer Types" report:

(old period)
image

(new period)
image

EDIT: this also affects the row evolution for that report (w/ regard to social networks at least).

@diosmosis commented on June 19th 2018 Member

Should there be a reattribution command for users that want to apply this to old data (eg, in order to segment by social network in old data)? I suppose they could segment by referrer URL, but I'm not so sure. (cc @mattab)

@diosmosis commented on June 19th 2018 Member

Probably doesn't have to be fixed by this PR, but I notice in the "all referrers" report, social networks are links, but websites aren't:

image

Seems inconsistent.

@diosmosis commented on June 19th 2018 Member

In the visitor log the social referrer is a link, but in the visitor profile it's not:

image

Should it be a link there?

@mattab commented on June 19th 2018 Member

Should there be a reattribution command for users that want to apply this to old data (eg, in order to segment by social network in old data)? I suppose they could segment by referrer URL, but I'm not so sure.

maybe this could be a separate issue, but not needed for now to implement it.

@sgiehl commented on June 19th 2018 Member

I've updated the code according to the review comments.

For dates before this goes into effect, I see that 'Social Networks' isn't added to the "Referrer Types" report:

That's not easily doable without reprocessing the reports, as the old reports for referrer type did not include that metric. Instead the social networks were included in the websites metric.

@diosmosis commented on June 20th 2018 Member

That's not easily doable without reprocessing the reports, as the old reports for referrer type did not include that metric. Instead the social networks were included in the websites metric.

I thought you could do the same thing for when there is no social data in Referrers.getSocials in Referrers.getReferrerType. Ie, if $idSubtable == REFERRER_TYPE_SOCIAL and there is no data returned by the getSocials method, then build the datatable from the getWebsites() result. I guess you would also have to remove social URLs from the getWebsites() result if $idSubtable == REFERRER_TYPE_WEBSITE. I guess this isn't doable? Of course, I haven't thought it through to the point that I know it'll work.

@sgiehl commented on July 9th 2018 Member

I thought you could do the same thing for when there is no social data in Referrers.getSocials in Referrers.getReferrerType. Ie, if $idSubtable == REFERRER_TYPE_SOCIAL and there is no data returned by the getSocials method, then build the datatable from the getWebsites() result. I guess you would also have to remove social URLs from the getWebsites() result if $idSubtable == REFERRER_TYPE_WEBSITE. I guess this isn't doable? Of course, I haven't thought it through to the point that I know it'll work.

Sorry for the delay. The referrer type numbers shown in that table are stored in an extra report. Splitting up the number for websites and socials for older data is not easy. We would need to query the reports for websites and split it up to websites and socials and then calculate all the numbers based on those resulting reports. I think that might be getting very slow when e.g. viewing row evolution. Also those referrer type reports are calculated as goal reports. I guess recalculating those would only be possible by reprocessing the logs.
Also the resulting numbers might differ if e.g. a website has more referrers than the report limit allows. While the calculated type report would show the correct number, the websites reports would only contain the limited dataset...

@tsteur commented on July 9th 2018 Member

Left a few minor comments... we will then definitely need to check which plugins need updating. I think eg funnels, multi attribution ...

@sgiehl commented on July 16th 2018 Member

@tsteur I've improved the code according to your suggestions. I've not yet done a profiling and don't know when I will find some time to do that properly.
But actually the filters aren't new. Those filters were used before to generate the social networks reports on the fly as well...

@tsteur commented on July 16th 2018 Member

Should be all fine then @sgiehl if they were all there before. If there are new ones, be good to have a look just to be sure.

This Pull Request was closed on July 23rd 2018
Powered by GitHub Issue Mirror