Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog url in update notification mail #12992

Merged

Conversation

abeutel
Copy link
Contributor

@abeutel abeutel commented May 26, 2018

Fixes #12991

@sgiehl
Copy link
Member

sgiehl commented May 26, 2018

@abeutel Thanks for the PR. would you mind updating the failing test as well?
https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/CoreUpdater/tests/Integration/UpdateCommunicationTest.php#L80

@abeutel abeutel force-pushed the bugfix-notification-mail-urls-12991 branch from 91f8295 to a5b727e Compare May 26, 2018 16:28
@abeutel
Copy link
Contributor Author

abeutel commented May 26, 2018

@sgiehl Done! Only one test failing now but I don't see how my change could influence the dashboard... anything else I missed?

@sgiehl
Copy link
Member

sgiehl commented May 26, 2018

That one is unrelated. All fine now 👍

@sgiehl sgiehl merged commit 4a5b52d into matomo-org:3.x-dev May 26, 2018
@sgiehl sgiehl changed the title Fix changelog url in update notification mail (#12991) Fix changelog url in update notification mail May 26, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone May 26, 2018
@sgiehl sgiehl added the Bug For errors / faults / flaws / inconsistencies etc. label May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants