Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully fix random failing ApiCounterTest on travis. #12977

Merged
merged 1 commit into from May 24, 2018

Conversation

diosmosis
Copy link
Member

Changes:

  • Use DI to inject test now value for ApiCounterTest.

@diosmosis diosmosis added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 24, 2018
@diosmosis diosmosis added this to the 3.5.1 milestone May 24, 2018
@mattab
Copy link
Member

mattab commented May 24, 2018

Tests are passing, so merging 👍

@mattab mattab merged commit 61bf67b into 3.x-dev May 24, 2018
@sgiehl sgiehl deleted the api-counter-test-randomness branch August 1, 2018 16:10
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants