Remove constraint for PHP 5.6 in scheduled report image generation check in tests. #12971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
c: Tests & QA
mattab
added
Needs Review
sgiehl
force-pushed
the
image-system-test-tweak
branch
from
b975100
to
d2db0a2
Compare
|
Just tested that with my PHP 7.1.3 and GD 2.1.1. While PDF tests work fine, the HTML reports fail with changed images. Maybe it would work with GD 2.1.0, but don't have enough time to set up an instance with that specific version right now |
|
I tested this as well and it's strange it works sometimes and sometimes not... anyway it's not super important, so I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my docker image which uses PHP 7.1 w/ a 2.1.0 compatible GD, I am able to run the scheduled report tests that generate images w/o issue (and they generate the same results as on travis). So I think the check for PHP 5.6 here might not be needed.
Could someone confirm? If it's really not needed, removing the line would make it a little bit easier for me to run them locally.