Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Referrer Type to Acquisitions Type (or Channel) #12969

Closed
tsteur opened this issue May 23, 2018 · 0 comments · Fixed by #13447
Closed

Rename Referrer Type to Acquisitions Type (or Channel) #12969

tsteur opened this issue May 23, 2018 · 0 comments · Fixed by #13447
Assignees
@tsteur
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
3.8.0

Comments

@tsteur
Copy link
Member

tsteur commented May 23, 2018

In #12750 we renamed the menu item Referrer to Acquisitions. It would be good to also rename the "Referrer Type" report for consistency.
@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label May 23, 2018
@tsteur tsteur added this to the 3.6.0 milestone May 23, 2018
@diosmosis diosmosis modified the milestones: 3.6.0, 3.7.0 Jul 24, 2018
tsteur added a commit that referenced this issue Sep 18, 2018
@tsteur
Rename Referrer Type to Channel Type
7e60b0e 
fixes #12969 

I think it makes things slightly better but all good if we don't want to merge it. Uses more common (marketing) terms for it instead of the technical terms IMO.
@tsteur tsteur mentioned this issue Sep 18, 2018
Merged
@tsteur tsteur self-assigned this Sep 18, 2018
tsteur added a commit that referenced this issue Nov 25, 2018
@tsteur
Rename Referrer Type to Channel Type (#13447)
ae0460f 
* Rename Referrer Type to Channel Type

fixes #12969 

I think it makes things slightly better but all good if we don't want to merge it. Uses more common (marketing) terms for it instead of the technical terms IMO.

* fix various tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Rename Referrer Type to Channel Type matomo-org/matomo
2 participants
@diosmosis @tsteur