Slightly faster location provider instance creation #12967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, on each tracking request it checks for each location provider whether each location provider is available which can put a bit of load on the filesystem etc. Instead we should check it only for the requested provider. Maybe we could even cache at some point whether a provider is available or not! Also ideally eventually we would be able to directly create an instance of the needed provider but that shouldn't improve performance crazy much.
tsteur
added
c: Performance
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
Currently, on each tracking request it checks for each location provider whether each location provider is available which can put a bit of load on the filesystem etc. Instead we should check it only for the requested provider. Maybe we could even cache at some point whether a provider is available or not! Also ideally eventually we would be able to directly create an instance of the needed provider but that shouldn't improve performance crazy much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on each tracking request it checks for each location provider whether each location provider is available which can put a bit of load on the filesystem etc. Instead we should check it only for the requested provider. Maybe we could even cache at some point whether a provider is available or not! Also ideally eventually we would be able to directly create an instance of the needed provider but that shouldn't improve performance crazy much.