New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved glossary and let plugins add items to it #12958
Conversation
Failing UI tests do not seem to be related to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. We could maybe add a UI test for the glossary
CHANGELOG.md
Outdated
@@ -9,6 +9,7 @@ The Product Changelog at **[matomo.org/changelog](https://matomo.org/changelog)* | |||
### New APIs | |||
|
|||
* Added new method `Piwik\API\Request::isRootRequestApiRequest()` to detect if the root request is an API request. | |||
* Added new event `API.addGlossaryItems` which lets you add items to the glossary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be moved to the correct place before merging
The glossary looks great 👍 |
* Improved glossary and let plugins add items to it * fix posted param * added pushpin feature * show keyword only for metrics * added UI test * update changelog * fix ui tests
The current glossary is pretty plain and a bit hard to read and does not even have category titles like "Reports" or "Metrics" see https://glossary.matomo.org/
As I needed to generalize the glossary a bit more so plugins can modify the glossary, I tweaked it a bit using Materialize components tabs, scrollspy and pagination.
Might need to update the changelog if we put this into 3.6.0. I presume for 3.5.1 we don't have enough time.