Rename Actions category to Behavior + Referrers category to Acquisition #12950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on while retaining category ID.
diosmosis
added
not-in-changelog
tsteur
reviewed
May 22, 2018
plugins/API/WidgetMetadata.php
Outdated
| @@ -178,7 +178,7 @@ private function buildCategoryMetadata($category) | |||
|
|
|||
| return array( | |||
| 'id' => (string) $category->getId(), | |||
| 'name' => Piwik::translate($category->getId()), | |||
| 'name' => Piwik::translate($category->getDisplayName()), | |||
There was a problem hiding this comment.
FYI the Piwik::translate is not needed here
|
@diosmosis some tests are failing, otherwise looks good to me 👍 |
diosmosis
force-pushed
the
12750-rename-actions-referrers
branch
from
913dd24
to
4718b81
Compare
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…on (matomo-org#12950) * Rename Actions category to Behavior + Referrers category to Acquisition while retaining category ID. * quick fix * Update expected system test files. * Updating screenshots & fixing test. * fix dashboard test * Update screenshots again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
getDisplayName()method to Category so original ID is retained.Fixes #12750