Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undefined APIRequest in Visualization.php #12947

Merged
merged 1 commit into from May 21, 2018

Conversation

bagbag
Copy link
Contributor

@bagbag bagbag commented May 21, 2018

I have no clue how this worked all the time, but after migrating to a new Server I always got an error on all visualizations.
After investigating that further, I found out that APIRequest is not defined, but ApiRequest is (line 32). After changing that, everything works.

I haven't done any extensive testing or anything like that, but as it is a really small change on a misspelling (?), I hope that's fine.

I have no clue how this worked all the time, but after migrating to a new Server I always got an error on all visualizations.
After investigating that further, I found out that APIRequest is not defined, but ApiRequest is (line 32). After changing that, everything works.
@sgiehl
Copy link
Member

sgiehl commented May 21, 2018

Good catch, that needs to be changed indeed.
Guess you now have a new php version that cares more about case sensitive class names.

@sgiehl sgiehl added this to the 3.5.1 milestone May 21, 2018
@sgiehl sgiehl added the Bug For errors / faults / flaws / inconsistencies etc. label May 21, 2018
@sgiehl sgiehl merged commit 50db666 into matomo-org:3.x-dev May 21, 2018
@bagbag
Copy link
Contributor Author

bagbag commented May 21, 2018

I'm actually using HHVM. So it would have worked with PHP? Interesting, then that may even be an bug in HHVM not being compliant to PHP in this case.

@sgiehl
Copy link
Member

sgiehl commented May 21, 2018

It worked on PHP before. But we should use the names that are defined nevertheless 😄

InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
I have no clue how this worked all the time, but after migrating to a new Server I always got an error on all visualizations.
After investigating that further, I found out that APIRequest is not defined, but ApiRequest is (line 32). After changing that, everything works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants