Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piwik.js JS Error in Firefox < 6 and Opera < Opera 11.60 #12936

Closed
MichaelRoosz opened this issue May 18, 2018 · 1 comment · Fixed by #13087
Closed

piwik.js JS Error in Firefox < 6 and Opera < Opera 11.60 #12936

MichaelRoosz opened this issue May 18, 2018 · 1 comment · Fixed by #13087
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.6.0

Comments

@MichaelRoosz
Copy link
Contributor

As documented here: https://www.w3schools.com/jsref/met_document_addeventlistener.asp
"The useCapture parameter became optional in Firefox 6 and Opera 11.60 (has always been optional for Chrome, IE and Safari)"

These two lines are missing the default "useCapture " value of "false":

matomo/js/piwik.js

Line 1295 in 7751aeb

windowAlias.addEventListener('load', callback);

matomo/js/piwik.js

Line 5480 in 7751aeb

documentAlias.addEventListener(events[index], setDidScroll);

@Findus23
Copy link
Member

FYI: The lines have been added in #10522

@sgiehl sgiehl mentioned this issue Jun 20, 2018
Merged
@sgiehl sgiehl self-assigned this Jun 20, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Jun 20, 2018
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging a pull request may close this issue.

Adds missing default value for addEventListener matomo-org/matomo
4 participants
@mattab @MichaelRoosz @sgiehl @Findus23