New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewdata refactoring #129
Merged
Merged
Viewdata refactoring #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…platform is displaying some data again
…it is a good idea but we will see
Conflicts: core/ViewDataTable.php plugins/CoreVisualizations/Visualizations/Cloud.php plugins/CoreVisualizations/Visualizations/HtmlTable/AllColumns.php
…r filters are applied. makes it easier to understand that this hook is meant to force the value of some config properties. this change probably breaks some features, will fix it then
… make the method static
…ewdata_refactoring
…irectly change the viewDataTable and there is support for auto completion now
…ass the view as a parameter to the filter and we can make this method reusable by moving it to the config
…uesting data table
…se any action module is requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.