@sgiehl opened this Pull Request on May 11th 2018 Member

Otherwise it's difficult to enable the module on nginx, as MMDB_ADDR or MMDB_INFO variables needs to be defined, which isn't the case.

See https://forum.matomo.org/t/geoip2-system-check-like/28251

@diosmosis commented on May 18th 2018 Member

UI test failures seem unrelated, but not sure why it fails w/ plugin_setting table does not exist...

@diosmosis commented on May 18th 2018 Member

Ok, found out why the UI tests fail:

Looks like the ConvertRegionCodesToIso command's isEnabled() method gets the current provider which tries to get the getGeoIpServerVars() system setting, but since the test database is being used, and it hasn't been created/setup yet, an exception is thrown.

Think a quick fix would be to just disable the command if PIWIK_TEST_MODE is defined.

This Pull Request was closed on May 22nd 2018
Powered by GitHub Issue Mirror