@c960657 opened this Pull Request on May 10th 2018 Contributor

Fix some menu items that are not translatable.

@tsteur commented on May 10th 2018 Member

fyi in theory changing Piwik Mobile App => Mobile_MatomoMobile' is somewhat breaking API so we should at least mention this in the developer changelog.

Why is this breaking API? Developers can hide menus using the menuItem, submenuItem name (translation key). If previously something was removed before based on that specific name, it will no longer work afterwards.

I don't think for those menu items it will be a big deal, but we might need to mention it?

@c960657 commented on May 11th 2018 Contributor

Ah, I didn't know that. I have added a note to the changelog.

This Pull Request was closed on June 10th 2018
Powered by GitHub Issue Mirror