@sgiehl opened this Pull Request on May 10th 2018 Member
  • permanently shows link to visitor profile in new line, with user id if available, otherwise visitor id is shown
  • adds visitor IP to country flag tooltip
  • readds provider name to country flag tooltip (if available)
  • improves styling

Note: the tooltip changes will also have effect in visitor log & profile

Changes will look like this:

image

fixes #12876
fixes #12887

@mattab commented on May 17th 2018 Member

Feedback:

  • when User ID is defined, it's great to display it, and when it's not defined we don't want to show visitor id. So when User ID is defined, maybe it's acceptable to introduce a new line and write the User ID on the new line, but maybe first try display User ID on the right of the icon of Visitor profile?
  • let's not use a new line for the visitor profile. It should be fine to update the icon on the first line to the font icon... or alternatively add it to the second line with all the other icons
  • Also another unrelated feedback: the space between the line of icons and the search engine row, is taller than the space between datetime and icons. Let's make all spacing consistent. Also let's check at different resolutions, and different column layouts, as it can change the look of the widget.
@sgiehl commented on May 17th 2018 Member

when User ID is defined, it's great to display it, and when it's not defined we don't want to show visitor id. So when User ID is defined, maybe it's acceptable to introduce a new line and write the User ID on the new line, but maybe first try display User ID on the right of the icon of Visitor profile?

I decided to add the visitorid in order to have a bit more consistency. We already displayed the visitor profile icon and the user id before. But to be honest, I never recognized that it has been displayed. The small icon behind the time was quite invisible. Imho it's ugly from UI/UX perspective if the icon/link can be found on different places (behind the date or on new line depeding on the available space). Now it's always at the same position and easy to find and click.

let's not use a new line for the visitor profile. It should be fine to update the icon on the first line to the font icon... or alternatively add it to the second line with all the other icons

The icons displayed here are generated with the same code as in visitor log and profile. I really would like to keep the consistency between all widgets/reports, so it's clear to the user which information can be found within the icon list. Imho that improves the UX a lot. Even if we already added various special handling for log/profile/widget so specific icons are not displayed in some parts, I would avoid changing more stuff here.

@diosmosis commented on May 18th 2018 Member

👍 to show visitor id if no userid, would confuse me otherwise to see it one place and not the other. Though maybe it would be clearer to have '(Unknown user)' or something instead? Just some thoughts.

Powered by GitHub Issue Mirror