FYI: Merging this PR would break https://github.com/matomo-org/tracker-proxy/pull/37 which we finished yesterday cc @diosmosis
This PR should now also work with the patched tracker-proxy which PR is referenced above. To accieve this an additional get parameter (
matomoproxy) is added on the proxy. If it doesn't exist in the request of the opt-out iframe the normal path
If the parameter
matomoproxy exists it will use
?module=CoreAdminHome&action=getOptOutJs as path for the script which is translated by the proxy to the normal path which then will be returned.
I'm not that familiar with the matomo routing so if there is a better way to do this please tell me.
I don't think using a special URL that doesn't actually work in matomo (ie, the
?module=CoreAdminHome&action=getOptOutJs) as a sort of message passing between matomo and the tracker-proxy is a good idea. It's not really clear from looking at the matomo code that this is what that special URL is for and it couples two entire repos together.
This should ideally be handled entirely in the tracker-proxy (so matomo doesn't have to know the tracker-proxy exists). Something like, in the tracker-proxy for matomo-proxy.php, rewriting URLs to JS/CSS files in the output to point to matomo-proxy.php instead (eg,
@mattab Can you take an other look at the branches. I changed the proxy.php to replace the path in the content to point to the
If that is ok with you I would create a new PR for the proxy and master
BTW, if you could create a PR for your tracker-proxy changes (which in general look good), that would be helpful.
Yes files shouldn't be there. Maybe leftovers from setup or phpunit.
PR 42 of matomo-proxy referenced above should contain that changes. Do you want to reopen that PR or shall I create a new one?
I'll reopen it.