Add rel="noopener noreferrer" to a link #12861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best practise for link using target="_blank". See https://medium.com/@jitbit/target-blank-the-most-underestimated-vulnerability-ever-96e328301f4c for details.
|
Thanks @nico3333fr and congratulation to the first PR 馃帀 Using noreferrer is definitely a good idea. @c960657 is currently going through all external links in #12780 so this is related. |
tsteur
approved these changes
May 8, 2018
Findus23
approved these changes
May 8, 2018
|
Thanks for the PR! FYI there are 2 tests failing (There are actually more tests failing but they are unrelated to this PR, we'll need to fix them as soon as doable cc @sgiehl @diosmosis ) |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Add rel="noopener noreferrer" to target="_blank" a Best practise for link using target="_blank". See https://medium.com/@jitbit/target-blank-the-most-underestimated-vulnerability-ever-96e328301f4c for details. * update test * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
first thanks for Matomo, I use it on several website, really happy with it. 馃憤
While running a detectify on one of my website, it found that the
piwik/piwik.phpis giving this textThis resource is part of Matomo. Keep full control of your data with the leading free and open source digital analytics platform for web and mobile.with a link to Matomo usingtarget="_blank".And it advised me to add
rel="noopener noreferrer"to this link, which is indeed, a good security pratice, see https://medium.com/@jitbit/target-blank-the-most-underestimated-vulnerability-ever-96e328301f4c for example.I've modified all the files where I found it, hope this will be enough.
Cheers,
Nicolas