Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use same userId hash on same site #12840

Closed
wants to merge 3 commits into from
Closed

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 7, 2018

@mattab I figured it may be better to use a different userId hash per site.

Eg when many websites are tracked on the same Matomo, for example in an agency, then the same userId would always have a different hash per site which may be better and further anonymize the data.

On the other side it is maybe wanted to have the same userId across sites but then they could still not use this feature and "pseudo" anonymize the userId themselves.

I have no preference whether it gets merged or not.

@tsteur tsteur added the Needs Review PRs that need a code review label May 7, 2018
@tsteur tsteur added this to the 3.5.0 milestone May 7, 2018
@mattab
Copy link
Member

mattab commented May 7, 2018

I think if we consider that we are transparent about pseudo anonymising (which we are now), then we likely don't need to do more work to make it less easy to guess the User ID.

It would more important to let data subject export work with the Hashed user id see: #12839 (If we made the User ID hash different for each website ID, it makes it a bit more tricky (although still do-able), to export the data subject data across all websites.)

@mattab mattab removed this from the 3.5.0 milestone May 7, 2018
@tsteur
Copy link
Member Author

tsteur commented May 7, 2018

Sweet, I close it then. Re #12839 I left comment and don't think this should work. Before that you should rather remove the feature!

@tsteur tsteur closed this May 7, 2018
@tsteur tsteur deleted the useridanonymization branch December 16, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants