Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the feature to set a custom action name "action_default_name" #12809

Open
mattab opened this issue May 2, 2018 · 0 comments
Open

Remove the feature to set a custom action name "action_default_name" #12809

mattab opened this issue May 2, 2018 · 0 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@mattab
Copy link
Member

mattab commented May 2, 2018

When features are not useful, or even documented, it's a good idea to remove them and keep the code simpler.

Steps:

  • Let's remove completely the feature provided by this INI setting:

; this action name is used when the URL ends with a slash /
; it is useful to have an actual string to write in the UI
action_default_name = index

  • When removing this, the code introduced here: https://github.com/matomo-org/matomo/pull/12669/files#diff-25480e51390b4cbc5cf99a0721101188 can also be removed.

  • Because the value was set to index by default, all archived data will include records with /index as the page URL. So after removing this feature, there will be two entries, one for /index and one for /. Maybe we could somehow merge/group the two rows together, and keep the data correct, this would be ideal to prevent confusion of having 2 rows for the same page.

Following up: #12669

@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants