Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower limit from 500 to 400 when searching for visits in GDPR data subject search #12803

Merged
merged 1 commit into from May 1, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 30, 2018

I searched for visits in the data subjects export/delete feature (Admin => GDPR tools).

It found 500 visits, when I then clicked on export, the request failed due to missing permissions. This was because the token_auth wasn't available in PHP even though it was sent as part of the request. It worked once I selected 10 less visits. I presume it might be the body length request limit or something that cut part of the request body. Changing it to 400 should improve this but eventually might need to lower it even further and if needed advice users to increase request limit (if that was the problem).

@tsteur tsteur added the Needs Review PRs that need a code review label Apr 30, 2018
@tsteur tsteur added this to the 3.5.0 milestone Apr 30, 2018
@diosmosis diosmosis merged commit 0e7f6e2 into 3.x-dev May 1, 2018
@diosmosis diosmosis deleted the gdprexportlimit branch May 1, 2018 02:22
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants