New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use https protocol in tracking code if force_ssl is enabled #12799
Conversation
Many thanks! 🎉 I'd go even a step further and document somewhere that the non-https tracking codes should be replaced. |
LGTM, but 👍 to let users know in some way if they're using force_ssl and their tracking code is http://, that it needs to change. Maybe a new diagnostic and/or some kind of notification? |
Actually, one thing, can we add a test to |
@diosmosis In addition the same issue is with people using Do you have any idea on how to detect this (as depending on webserver config the HTTP request never reaches Matomo)? |
I was imagining a diagnostic that would request the site's page server side and look for the tracking code (as I believe GA does). |
@diosmosis That sounds like a good idea (even though it may not work in some situations). Maybe a server-based debugging tool is more successful than my browser-extension-based one. |
+1 for adding some type of diagnostic for that. But maybe we should handle that in another issue/pr as I'm not sure if we can handle that before the release of 3.5.0 |
I'll create an issue later today. |
💯 |
Created new issue here: #12801 |
…rg#12799) * Use https protocol in tracking code if force_ssl is enabled * Add tracking code generator test for force_ssl = 1.
fixes #7366