Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show number of Goals created in the System summary widget #12798

Merged
merged 2 commits into from May 2, 2018
Merged

Show number of Goals created in the System summary widget #12798

merged 2 commits into from May 2, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 30, 2018

fixes #12794

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 30, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Apr 30, 2018
@tsteur
Copy link
Member

tsteur commented Apr 30, 2018

Haven't tested it manually but from the test looks like it works. And code looks 👍 GTM IMO

@mattab mattab merged commit 22e958e into 3.x-dev May 2, 2018
@mattab mattab deleted the goalsinsystemsummary branch May 2, 2018 08:11
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Show number of Goals created in the System summary widget (matomo-org…
0063a73 
…#12798)

* Show overall goal count in system summary

* update UI files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Show number of Goals created in the System summary widget
3 participants
@sgiehl @tsteur @mattab