Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to specify an icon and onclick handler for submenu items #12791

Merged
merged 1 commit into from Apr 30, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 30, 2018

I needed this feature for the admin menu template.

It's basically like this:

image

It doesn't load a new page but instead executes an action directly. Couldn't find a different place to put such an action and thinking the menu is the best for it as the context is there.

@tsteur tsteur added the Needs Review PRs that need a code review label Apr 30, 2018
@tsteur tsteur added this to the 3.5.0 milestone Apr 30, 2018
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@diosmosis
Copy link
Member

Instead of two new properties, what do you think about allowing a custom angular component to be used for the link? Then it could be customized in many different ways.

@tsteur
Copy link
Member Author

tsteur commented Apr 30, 2018

Then it could be customized in many different ways.

We could add this at some point as well, however, I don't really want to let people customize there too much as we want to ensure same look & feel and behavior and not introduce too many new concepts there

@tsteur tsteur merged commit 8d9d5ed into 3.x-dev Apr 30, 2018
@tsteur tsteur deleted the menuiconclick branch April 30, 2018 19:15
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants