Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use JS handler for installing all paid plugins #12783

Merged
merged 1 commit into from Jul 24, 2018
Merged

use JS handler for installing all paid plugins #12783

merged 1 commit into from Jul 24, 2018

Conversation

Findus23
Copy link
Member

fixes #12782

I am not entirely sure if this is the most elegant solution, but this way the modal works as every other one.
grafik

I only need a solution on how to mark the install button as primary.

@Findus23 Findus23 added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Apr 28, 2018
tsteur
tsteur reviewed Apr 29, 2018
View reviewed changes
plugins/Marketplace/templates/paid-plugins-install-list.twig
<a href="{{ linkTo({'rand': random(999999)}) }}" class="btn-flat">
Cancel
</a>
<input role="install" type="button" data-href="{{ linkTo({'action': 'installAllPaidPlugins', 'nonce': installNonce}) }}"
Copy link
Member

@tsteur tsteur Apr 29, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it but this makes sense I presume. The previous style was not the common "style".

@mattab mattab added Needs Review PRs that need a code review and removed Needs Review PRs that need a code review labels Jun 26, 2018
@mattab mattab added this to the 3.6.0 milestone Jun 26, 2018
@tsteur tsteur merged commit b7e77d8 into 3.x-dev Jul 24, 2018
@tsteur tsteur deleted the modal-close branch July 24, 2018 22:26
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 28, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@Findus23 @InfinityVoid
use JS handler for installing all paid plugins (matomo-org#12783)
ae1432b
@Findus23 Findus23 restored the modal-close branch October 4, 2019 09:48
@sgiehl sgiehl deleted the modal-close branch February 10, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Canceling Install purchased plugins doesn't close the popup
3 participants
@Findus23 @tsteur @mattab