Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piwik.js minification: use newer yuicompressor version #12774

Merged
merged 3 commits into from May 1, 2018
Merged

piwik.js minification: use newer yuicompressor version #12774

merged 3 commits into from May 1, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 27, 2018 •
edited

@tsteur
Recommend newer yuicompressor version
7e1aec6 
Fixes some bugs in version 2.4.7
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 27, 2018
@tsteur tsteur added this to the 3.5.0 milestone Apr 27, 2018
@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. and removed Needs Review PRs that need a code review labels Apr 27, 2018
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Apr 27, 2018
sgiehl
sgiehl approved these changes Apr 28, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diosmosis diosmosis merged commit 9c0a0f5 into 3.x-dev May 1, 2018
@diosmosis diosmosis deleted the yuicompressorupdate branch May 1, 2018 00:21
@mattab mattab changed the title Recommend newer yuicompressor version piwik.js minification: use newer yuicompressor version May 8, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@tsteur @InfinityVoid
Recommend newer yuicompressor version (matomo-org#12774)
d39277a 
* Recommend newer yuicompressor version

Fixes some bugs in version 2.4.7

* use newer yuicompressor version

* fix line ending
@Findus23 Findus23 mentioned this pull request Jan 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @sgiehl @diosmosis