@mattab opened this Issue on April 26th 2018 Member

Minor feedback: in Visitor Log, some icons are not vertically aligned.
In this example you can see that while the Conversion icon is middle aligned, the Content Tracking icons are not (they are slightly too high).

Example 1: content interaction too high

content tracking

Example 2: content impression too high

sne

Example 3: outlinks too low

too low

@fdellwing commented on April 26th 2018 Contributor

Should be possible with CSS.

plugins/Live/stylesheets/live.less - Line 295ff

.action-list-action-icon {
    display: inline;
    margin: 2px 3px 0 0;
    max-height: 16px;

    &.outlink {
      margin: 7px 3px 0 0;
    }
}

outlink is the action.type here coming from <img src='{{ action.icon }}' class="action-list-action-icon {{ action.type }}"> in plugins/Live/templates/_actionCommon.twig

@mattab commented on April 30th 2018 Member

@fdellwing thanks for the suggestion. Would be great if you can test the change works and then create a Pull request :+1:

@fdellwing commented on May 2nd 2018 Contributor

Sadly I do not have a instance with all with symbols. Will look into this.

@mattab commented on October 8th 2018 Member

Hi @fdellwing
Would you maybe able to test your changes and open a PR so we can see the failing tests and if it fixes issue?

@fdellwing commented on October 8th 2018 Contributor

@mattab
Is there somethere an otherview with all possible action types? I have sadly no time for researching that myself.

@sgiehl commented on October 8th 2018 Member

Some are handled here: https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Live/VisitorDetails.php#L71-L85
Additionally some plugins add some more. like event or form

@fdellwing commented on October 8th 2018 Contributor

The problem is, we do not have all this action type on our site (we have no ecommerce) and the CSS needs to be handcrafted for every single type.

@mattab commented on October 8th 2018 Member

You could generate a tracking api request with the Contents parameter see:

Optional Content Tracking info

  • c_n — The name of the content. For instance 'Ad Foo Bar'
  • c_p — The actual content piece. For instance the path to an image, video, audio, any text
  • c_t — The target of the content. For instance the URL of a landing page
  • c_i — The name of the interaction with the content. For instance a 'click'

To track a content impression set c_n and optionally c_p and c_t. To track a content interaction set c_i and c_n and optionally c_p and c_t. To map an interaction to an impression make sure to set the same value for c_n and c_p. It is recommended to set a value for c_p.

Powered by GitHub Issue Mirror