Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Super users are not anonymous #12766

Merged
merged 3 commits into from May 21, 2018
Merged

Super users are not anonymous #12766

merged 3 commits into from May 21, 2018

Conversation

letharion
Copy link
Contributor

Don't consider the user anonymous when they have super user privileges.

@letharion
Super users are not anonymous
f8da40f 
Don't consider the user anonymous when they have super user privileges.
@letharion letharion mentioned this pull request Apr 23, 2018
Closed
@mattab mattab added the Needs Review PRs that need a code review label Apr 24, 2018
@mattab mattab added this to the 3.6.0 milestone Apr 24, 2018
@mattab mattab modified the milestones: 3.6.0, 3.5.1 May 16, 2018
@diosmosis
Copy link
Member

diosmosis commented May 18, 2018 •
edited

Is it possible for a user named anonymous to have superuser access? Or is this to aid in development when, eg, calling Access::doAsSuperUser()?

EDIT: saw the linked ticket, looks good to me, though would be nice to have a test for this change in https://github.com/matomo-org/matomo/blob/3.x-dev/tests/PHPUnit/Integration/AccessTest.php

diosmosis
diosmosis requested changes May 18, 2018
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment about adding a test

@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label May 21, 2018
@diosmosis diosmosis merged commit 479f34e into matomo-org:3.x-dev May 21, 2018
@mattab
Copy link
Member

mattab commented May 25, 2018

👍 for adding tests @diosmosis

InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@letharion @InfinityVoid
Super users are not anonymous (matomo-org#12766)
042f2f0 
* Super users are not anonymous

Don't consider the user anonymous when they have super user privileges.

* Add some tests for Piwik::isUserIsAnonymous().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis requested changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@letharion @diosmosis @mattab