Fix syntax for 'SHOW COLUMNS FROM' on MySQL 8 #12759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good find 👍 |
|
This bug actually breaks Matomo on systems with MySQL 8. Installation fails on the last step and previously installed deployments just stop working. |
sgiehl
approved these changes
Apr 23, 2018
sgiehl
changed the title
mattab
added a commit
that referenced
this pull request
Apr 23, 2018
…"" (#12761) * Revert "Fix syntax vor 'SHOW COLUMNS FROM' (#12759)" This reverts commit f69c1f6. * Revert "fix #12722 (#12756)" This reverts commit 6c3ed18. * Revert "When setting or resetting User ID, do not update the Visitor ID in the first party cookie (#12742)" This reverts commit fdb161b. * Revert "Show information in visitor profile if dataset was "truncated" (#12376)" This reverts commit 14ba6a4.
mattab
changed the title
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…"" (matomo-org#12761) * Revert "Fix syntax vor 'SHOW COLUMNS FROM' (matomo-org#12759)" This reverts commit f69c1f6. * Revert "fix matomo-org#12722 (matomo-org#12756)" This reverts commit 6c3ed18. * Revert "When setting or resetting User ID, do not update the Visitor ID in the first party cookie (matomo-org#12742)" This reverts commit fdb161b. * Revert "Show information in visitor profile if dataset was "truncated" (matomo-org#12376)" This reverts commit 14ba6a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing quotation mark in this line seem to be placed at the wrong place:
matomo/core/Db/Schema/Mysql.php
Line 321 in 6c3ed18
Should be:
MySQL in versions < 8 ignores this error and assumes the dot indicates a database name before the tablename which apparently can be empty.