Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core:purge-old-archive-data failing in some cases #12757

Merged
merged 1 commit into from Apr 23, 2018
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 23, 2018

If tables with names like piwik_archive_numeric_1875_09 exist for any reason, the archive purger will fail, as the date information in the name couldn't be used to create a Date object...

I'm not 100% sure why such tables could have been created in the first place, but maybe we had a bug in the archiving sometimes that allowed triggering the archiving for any date given? Wasn't able to do so locally with current version.

fixes #11778

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 23, 2018
@mattab mattab merged commit 97e9921 into 3.x-dev Apr 23, 2018
@sgiehl sgiehl deleted the 11778_fix branch April 23, 2018 08:56
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running "./console core:purge-old-archive-data all" fails on some system with [Exception] Date format
2 participants