Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party cookie visitor ID value should not change over time #12755

Merged
merged 4 commits into from Apr 24, 2018

Conversation

mattab
Copy link
Member

@mattab mattab commented Apr 23, 2018

Once a 3rd party cookie is set, we persist it and don't overwrite the 3rd party cookie value, even when the visitor id may change in the backend, or for a specific website. This makes the 3rd party analytics cookie more useful and actually working as you'd expect.

Recreates #12592

@mattab mattab added the Needs Review PRs that need a code review label Apr 23, 2018
@mattab mattab added this to the 3.5.0 milestone Apr 23, 2018
@mattab mattab changed the title Michael heerklotz fix pk uid 3rd party cookie visitor ID value should not change over time Disable visitorid overrides for third party cookie Apr 23, 2018
@mattab mattab changed the title 3rd party cookie visitor ID value should not change over time Disable visitorid overrides for third party cookie 3rd party cookie visitor ID value should not change over time Apr 23, 2018
mattab added a commit to matomo-org/plugin-QueuedTracking that referenced this pull request Apr 23, 2018
@mattab mattab merged commit b91857f into 3.x-dev Apr 24, 2018
@mattab mattab deleted the MichaelHeerklotz-fix_pk_uid branch April 24, 2018 01:29
mattab added a commit to matomo-org/plugin-QueuedTracking that referenced this pull request Jun 28, 2018
* 3rd party cookie visitor ID value should not change over time

Refs matomo-org/matomo#12755

* Update plugin.json
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…-org#12755)

* Disable visitorid overrides for third party cookie

* Refactor the change into a new method for clarity

* add logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant