Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When setting or resetting User ID, do not update the Visitor ID in the first party cookie #12742

Merged
merged 3 commits into from Apr 23, 2018

Conversation

mattab
Copy link
Member

@mattab mattab commented Apr 19, 2018

Refs #7691 (comment)

One first small step would be in the JS code, not to re-generate the Visitor ID when the User ID is set.

Expected that some JS tests will fail, will need to be fixed

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Apr 19, 2018
@mattab mattab added this to the 3.5.0 milestone Apr 19, 2018
@mattab mattab merged commit fdb161b into 3.x-dev Apr 23, 2018
@mattab mattab deleted the do_not_regenerate_visitorid branch April 23, 2018 04:30
mattab added a commit that referenced this pull request Apr 23, 2018
…ID in the first party cookie (#12742)"

This reverts commit fdb161b.
mattab added a commit that referenced this pull request Apr 23, 2018
…"" (#12761)

* Revert "Fix syntax vor 'SHOW COLUMNS FROM' (#12759)"

This reverts commit f69c1f6.

* Revert "fix #12722 (#12756)"

This reverts commit 6c3ed18.

* Revert "When setting or resetting User ID, do not update the Visitor ID in the first party cookie (#12742)"

This reverts commit fdb161b.

* Revert "Show information in visitor profile if dataset was "truncated" (#12376)"

This reverts commit 14ba6a4.
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…e first party cookie (matomo-org#12742)

* When setting or resetting User ID, do not update the Visitor ID in the first party cookie

* Forgot a file

* Fix the JS tracker tests
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…"" (matomo-org#12761)

* Revert "Fix syntax vor 'SHOW COLUMNS FROM' (matomo-org#12759)"

This reverts commit f69c1f6.

* Revert "fix matomo-org#12722 (matomo-org#12756)"

This reverts commit 6c3ed18.

* Revert "When setting or resetting User ID, do not update the Visitor ID in the first party cookie (matomo-org#12742)"

This reverts commit fdb161b.

* Revert "Show information in visitor profile if dataset was "truncated" (matomo-org#12376)"

This reverts commit 14ba6a4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant