piwikUrl.getSearchParam() should not set an empty URL value #12728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue that when changing for example the date, suddenly the log in screen is shown.
For example in a plugin I do
`var tokenAuth = piwikUrl.getSearchParam('token_auth')`
Which then sets indirectly `$search.token_auth=''` which then results in `&token_auth=undefined` in the URL. Meaning it will try to authenticate the user for the token `undefined` which won't work. Also I think in general we should not append the URL accidentally ever to the URL in the browser.
Ideally, the `getSearchParam()` method should certainly not set a value indirectly here and it is a bug but not sure what side effects we would run into by removing the `search[paramName] = paramUrlValue;`
See DEV-1316
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…rg#12728) This fixes an issue that when changing for example the date, suddenly the log in screen is shown. For example in a plugin I do `var tokenAuth = piwikUrl.getSearchParam('token_auth')` Which then sets indirectly `$search.token_auth=''` which then results in `&token_auth=undefined` in the URL. Meaning it will try to authenticate the user for the token `undefined` which won't work. Also I think in general we should not append the URL accidentally ever to the URL in the browser. Ideally, the `getSearchParam()` method should certainly not set a value indirectly here and it is a bug but not sure what side effects we would run into by removing the `search[paramName] = paramUrlValue;` See DEV-1316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that when changing for example the date, suddenly the log in screen is shown.
For example in a plugin I do
var tokenAuth = piwikUrl.getSearchParam('token_auth')Which then sets indirectly
$search.token_auth=''which then results in&token_auth=undefinedin the URL. Meaning it will try to authenticate the user for the tokenundefinedwhich won't work. Also I think in general we should not append the URL accidentally ever to the URL in the browser.Ideally, the
getSearchParam()method should certainly not set a value indirectly here and it is a bug but not sure what side effects we would run into by removing thesearch[paramName] = paramUrlValue;See DEV-1316