Fix SystemTests #12726
Merged
Fix SystemTests #12726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found `piwik`
|
Hi, if I checked correctly this, the test you edited checks the author of the SecurityInfo plugin. So to don't make the test fail, you'd need to also edit the authro of the plugin. |
|
@Findus23 I've made this change based on https://travis-ci.org/matomo-org/matomo/jobs/365433166#L872-L878 |
|
Then I guess I didn't check properly. |
|
SystemTests fixed: https://travis-ci.org/matomo-org/matomo/builds/366807249 Please merge. |
|
@mattab Could it be that PR-s are being merged for a long time with failing tests? |
|
Cheers 👍 |
mattab
added
the
not-in-changelog
c960657
pushed a commit
to c960657/matomo
that referenced
this pull request
Apr 19, 2018
Found `piwik`
|
@szepeviktor yes, this is the case. If you want to help make the builds green more often, we welcome your help! |
|
@mattab Could you copy it to the dev branch too please? |
|
Sorry |
|
@tsteur this PR is merged into |
mattab
pushed a commit
that referenced
this pull request
Apr 23, 2018
…nd multiple recorders. (#12733) * visitorGeolocator: output actual changes in debug mode (#12478) closes #12477 * Revert "visitorGeolocator: output actual changes in debug mode (#12478)" (#12480) This reverts commit 19a7654. * Fix SystemIntegration test (#12726) Found `piwik` * This addresses the various dead lock issues when using transactions and bulk load. Issue #6398 * Fix archive test to work with multi recorder fix. * Minor changes and renames
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…nd multiple recorders. (matomo-org#12733) * visitorGeolocator: output actual changes in debug mode (matomo-org#12478) closes matomo-org#12477 * Revert "visitorGeolocator: output actual changes in debug mode (matomo-org#12478)" (matomo-org#12480) This reverts commit 19a7654. * Fix SystemIntegration test (matomo-org#12726) Found `piwik` * This addresses the various dead lock issues when using transactions and bulk load. Issue matomo-org#6398 * Fix archive test to work with multi recorder fix. * Minor changes and renames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found one
piwik