@szepeviktor opened this Pull Request on April 15th 2018 Contributor

Found one piwik

@Findus23 commented on April 15th 2018 Member

Hi, if I checked correctly this, the test you edited checks the author of the SecurityInfo plugin.

So to don't make the test fail, you'd need to also edit the authro of the plugin.

https://github.com/matomo-org/plugin-SecurityInfo/blob/4d72dc5be011872d6f72ffd2ce3265cf8b4052ba/plugin.json#L17-L23

@szepeviktor commented on April 15th 2018 Contributor
@Findus23 commented on April 15th 2018 Member

Then I guess I didn't check properly.

@szepeviktor commented on April 15th 2018 Contributor
@szepeviktor commented on April 15th 2018 Contributor

@mattab Could it be that PR-s are being merged for a long time with failing tests?

@tsteur commented on April 15th 2018 Member

Cheers 👍

@mattab commented on April 23rd 2018 Member

@szepeviktor yes, this is the case. If you want to help make the builds green more often, we welcome your help!

@szepeviktor commented on April 23rd 2018 Contributor

@mattab Could you copy it to the dev branch too please?

@szepeviktor commented on April 23rd 2018 Contributor
@mattab commented on April 23rd 2018 Member

@tsteur this PR is merged into master, should we revert it maybe?

This Pull Request was closed on April 15th 2018
Powered by GitHub Issue Mirror