Do not archive a period when a sub period is processing #12719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
Apr 23, 2018
* Do not run the same archive command twice * simplify * During core:archive when a day or period archiving fails for a website, abort the website archiving (#12708) * If one of the period archiving fails, we now cancel the remaining archiving processes * Increment the skipped counter * also exit when a day period is already active * undo last commit * if day archive fails, then do not proceed archiving periods * Minor changes * Archive: mark the daily archive as successful, only after it was really successful (#12720) + Simplify & fix some logic * do not archive a period when a sub period is processing (#12719)
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Do not run the same archive command twice * simplify * During core:archive when a day or period archiving fails for a website, abort the website archiving (matomo-org#12708) * If one of the period archiving fails, we now cancel the remaining archiving processes * Increment the skipped counter * also exit when a day period is already active * undo last commit * if day archive fails, then do not proceed archiving periods * Minor changes * Archive: mark the daily archive as successful, only after it was really successful (matomo-org#12720) + Simplify & fix some logic * do not archive a period when a sub period is processing (matomo-org#12719)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #12718 but couldn't really test it.
Initially I had a bit different solution where I tried to match exact date but the date in the cli command might be different every day and we should never execute for example any monthly archive if a weekly archive is active.
This PR is based on #12702 and this PR should be merged before #12702