Log a job ID for cli commands #12717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
approved these changes
Apr 12, 2018
|
instead of Fyi: a test or two in the build would need to be fixed |
|
|
|
Fixed the test |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* log requestId for cli commands * format console log * log pid for cli commands * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like this where 60d1f is the job ID in this case. We could also wrap it in brackets or something.
I'm not sure why this was disabled in the past for cli commands. I'm finding this super useful when investigating issues. For example imagine 2 or more
core:archive > archive.logare running at the same time. Now both jobs will be writing into that log and it is not clear which action is performed by which process. The requestId lets yougrepinformation only for a specific job for example and see when there were for example any possible concurrency issues etc.