@tsteur opened this Pull Request on April 12th 2018 Owner

looks like this where 60d1f is the job ID in this case. We could also wrap it in brackets or something.

image

I'm not sure why this was disabled in the past for cli commands. I'm finding this super useful when investigating issues. For example imagine 2 or more core:archive > archive.log are running at the same time. Now both jobs will be writing into that log and it is not clear which action is performed by which process. The requestId lets you grep information only for a specific job for example and see when there were for example any possible concurrency issues etc.

@mattab commented on April 12th 2018 Owner

instead of substr(Common::generateUniqId(), 0, 5); maybe we could use the current pid of the process? this way it could be grep'able if process is still running?

Fyi: a test or two in the build would need to be fixed

@diosmosis commented on April 12th 2018 Member

Piwik\Plugins\Monolog\tests\Integration\LogTest is failing now, otherwise good to merge

@tsteur commented on April 12th 2018 Owner

Fixed the test

This Pull Request was closed on April 12th 2018
Powered by GitHub Issue Mirror