@MichaelHeerklotz opened this Pull Request on April 10th 2018 Contributor

Possible bug fix: As I understand it, the "$currentProviderId ==" code part is a possible typo and should not be there.

Changed: Added IP2Location as a recommended geolocation provider. It is a actively maintained plugin that provides good location data.

@fdellwing commented on April 11th 2018 Contributor

Please see #12699

@sgiehl commented on April 21st 2018 Member

@MichaelHeerklotz thanks for the PR. The "fix" is already included in #12699.
I'm not sure if we should add third party providers as recommended "hard-coded" within Matomo.
But maybe we could make it possible to define additional recommended providers in config?
@mattab do you think it would make sense to define recommended providers in config.php using DI? If so I could add those changes to #12699

@mattab commented on April 23rd 2018 Member

The goal of the system check is to point out potential problems with the GeoIp providers that we offer by default. If the user has taken decision to use a Geolocation provider from the Marketplace (such as IP2Location), then the system check should be green. It's up to the third-party geolocation service to mention any limitation and problems on their page. Therefore, I suggest to automatically mark as Green the system diagnostic, when a third party location system is used.

@sgiehl could you maybe make this change in core so the system check works for all third party geolocation providers?

@mattab commented on April 23rd 2018 Member

Thanks for the suggestion @MichaelHeerklotz
@sgiehl let's make the change to accept all third party geolocation providers in a separate PR

@sgiehl commented on April 23rd 2018 Member

@mattab I will include it in #12699 to avoid later marge conflicts as I already changed some stuff there...

This Pull Request was closed on April 23rd 2018
Powered by GitHub Issue Mirror