Possible bug fix: As I understand it, the "$currentProviderId ==" code part is a possible typo and should not be there.
Changed: Added IP2Location as a recommended geolocation provider. It is a actively maintained plugin that provides good location data.
@MichaelHeerklotz thanks for the PR. The "fix" is already included in #12699.
I'm not sure if we should add third party providers as recommended "hard-coded" within Matomo.
But maybe we could make it possible to define additional recommended providers in config?
@mattab do you think it would make sense to define recommended providers in
config.php using DI? If so I could add those changes to #12699
The goal of the system check is to point out potential problems with the GeoIp providers that we offer by default. If the user has taken decision to use a Geolocation provider from the Marketplace (such as IP2Location), then the system check should be green. It's up to the third-party geolocation service to mention any limitation and problems on their page. Therefore, I suggest to automatically mark as Green the system diagnostic, when a third party location system is used.
@sgiehl could you maybe make this change in core so the system check works for all third party geolocation providers?